#70 window should not be added twice to the window-tree when deminimi…

…zed on inactive display
koekeishiya · Jun 25, 2019 · d732ee7 · d732ee7
1 parent 02d67c3
commit d732ee7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -14,6 +14,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
 - Silence meaningless warning reported by the scripting-bridge framework [#55](https://github.com/koekeishiya/yabai/issues/55)
 - Extend definition of *WINDOW_SEL* to include *mouse*, targetting the window below the cursor [#66](https://github.com/koekeishiya/yabai/issues/66)
 - Allow all *config* (except *status_bar*) settings to be edited at runtime [#69](https://github.com/koekeishiya/yabai/issues/69)
+- Window should not be added to the window-tree twice when deminimized on an inactive display [#70](https://github.com/koekeishiya/yabai/issues/70)
 
 ## [1.0.1] - 2019-06-23
 ### Added

diff --git a/src/window_manager.c b/src/window_manager.c
@@ -1264,6 +1264,7 @@ void window_manager_check_for_windows_on_space(struct space_manager *sm, struct
     for (int i = 0; i < window_count; ++i) {
         struct ax_window *window = window_manager_find_window(wm, window_list[i]);
         if (!window || !window_manager_should_manage_window(window)) continue;
+        if (window->is_minimized || window->application->is_hidden)  continue;
 
         struct view *existing_view = window_manager_find_managed_window(wm, window);
         if (existing_view && existing_view->sid != sid) {