Skip to content

Commit

Permalink
#1889 remove window borders because of various issues on Ventura and …
Browse files Browse the repository at this point in the history
…Sonoma
  • Loading branch information
koekeishiya committed Oct 10, 2023
1 parent 355a60c commit 5dd912f
Show file tree
Hide file tree
Showing 19 changed files with 30 additions and 853 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
- Window command `--toggle` option `topmost` has been removed [#1887](https://github.com/koekeishiya/yabai/issues/1887)
- Window query property `is-topmost` has been removed [#1887](https://github.com/koekeishiya/yabai/issues/1887)
- Signal `application_activated` and `application_deactivated` has been removed; use `application_front_switched` instead [#1887](https://github.com/koekeishiya/yabai/issues/1887)
- Window borders (and all related options/properties) have been removed [#1889](https://github.com/koekeishiya/yabai/issues/1889)

## [5.0.9] - 2023-10-01
### Changed
Expand Down
46 changes: 1 addition & 45 deletions doc/yabai.1
Original file line number Diff line number Diff line change
Expand Up @@ -258,43 +258,6 @@ Opacity of an unfocused window.
System Integrity Protection must be partially disabled.
.RE
.sp
\fBwindow_border\fP [\fI<BOOL_SEL>\fP]
.RS 4
Draw border for windows.
.RE
.sp
\fBwindow_border_hidpi\fP [\fI<BOOL_SEL>\fP]
.RS 4
Draw border in high resolution mode; for High Dots Per Inch ("Retina") displays.
.br
HiDPI uses significantly more memory.
.RE
.sp
\fBwindow_border_blur\fP [\fI<BOOL_SEL>\fP]
.RS 4
Blur border allowing it to act as a backdrop for transparent windows.
.RE
.sp
\fBwindow_border_width\fP [\fI<even integer number>\fP]
.RS 4
Width of window border. If the given width is an odd number, it will be incremented by 1.
.RE
.sp
\fBwindow_border_radius\fP [\fI<integer number>\fP]
.RS 4
Radius of window border.
.RE
.sp
\fBactive_window_border_color\fP [\fI0xAARRGGBB\fP]
.RS 4
Color of the border of the focused window.
.RE
.sp
\fBnormal_window_border_color\fP [\fI0xAARRGGBB\fP]
.RS 4
Color of the border of an unfocused window.
.RE
.sp
\fBinsert_feedback_color\fP [\fI0xAARRGGBB\fP]
.RS 4
Color of the \fBwindow \-\-insert\fP message selection.
Expand Down Expand Up @@ -529,7 +492,7 @@ Resize the selected window by moving the given handle \fIdx\fP pixels horizontal
If type is \fIrel\fP the split ratio of the selected window is changed by \fIdr\fP, otherwise \fIdr\fP will become the new split ratio. A positive/negative delta will increase/decrease the size of the left\-child.
.RE
.sp
\fB\-\-toggle\fP \fIfloat|sticky|pip|shadow|border|split|zoom\-parent|zoom\-fullscreen|native\-fullscreen|expose\fP
\fB\-\-toggle\fP \fIfloat|sticky|pip|shadow|split|zoom\-parent|zoom\-fullscreen|native\-fullscreen|expose\fP
.RS 4
Toggle the given property of the selected window.
.br
Expand Down Expand Up @@ -690,7 +653,6 @@ WINDOW
"can\-resize": bool,
"has\-focus": bool,
"has\-shadow": bool,
"has\-border": bool,
"has\-parent\-zoom": bool,
"has\-fullscreen\-zoom": bool,
"is\-native\-fullscreen": bool,
Expand Down Expand Up @@ -796,11 +758,6 @@ Window is ordered within the given stacking layer.
Set window opacity. The window will no longer be eligible for automatic change in opacity upon focus change.
.RE
.sp
\fBborder=\fI<BOOL_SEL>\fP\fP
.RS 4
Window should draw border.
.RE
.sp
\fBnative\-fullscreen=\fI<BOOL_SEL>\fP\fP
.RS 4
Window should enter native macOS fullscreen mode.
Expand Down Expand Up @@ -830,7 +787,6 @@ Set window frame based on a self\-defined grid.
"sticky": bool (optional),
"mouse_follows_focus": bool (optional),
"layer": string,
"border": bool (optional),
"native\-fullscreen": bool (optional),
"grid": string
}
Expand Down
29 changes: 1 addition & 28 deletions doc/yabai.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -181,28 +181,6 @@ Global Settings
Opacity of an unfocused window. +
System Integrity Protection must be partially disabled.

*window_border* ['<BOOL_SEL>']::
Draw border for windows.

*window_border_hidpi* ['<BOOL_SEL>']::
Draw border in high resolution mode; for High Dots Per Inch ("Retina") displays. +
HiDPI uses significantly more memory.

*window_border_blur* ['<BOOL_SEL>']::
Blur border allowing it to act as a backdrop for transparent windows.

*window_border_width* ['<even integer number>']::
Width of window border. If the given width is an odd number, it will be incremented by 1.

*window_border_radius* ['<integer number>']::
Radius of window border.

*active_window_border_color* ['0xAARRGGBB']::
Color of the border of the focused window.

*normal_window_border_color* ['0xAARRGGBB']::
Color of the border of an unfocused window.

*insert_feedback_color* ['0xAARRGGBB']::
Color of the *window --insert* message selection.

Expand Down Expand Up @@ -367,7 +345,7 @@ COMMAND
*--ratio* 'rel|abs:<dr>'::
If type is 'rel' the split ratio of the selected window is changed by 'dr', otherwise 'dr' will become the new split ratio. A positive/negative delta will increase/decrease the size of the left-child.

*--toggle* 'float|sticky|pip|shadow|border|split|zoom-parent|zoom-fullscreen|native-fullscreen|expose'::
*--toggle* 'float|sticky|pip|shadow|split|zoom-parent|zoom-fullscreen|native-fullscreen|expose'::
Toggle the given property of the selected window. +
The following properties require System Integrity Protection to be partially disabled: sticky, pip, shadow.

Expand Down Expand Up @@ -495,7 +473,6 @@ WINDOW
"can-resize": bool,
"has-focus": bool,
"has-shadow": bool,
"has-border": bool,
"has-parent-zoom": bool,
"has-fullscreen-zoom": bool,
"is-native-fullscreen": bool,
Expand Down Expand Up @@ -572,9 +549,6 @@ ARGUMENT
*opacity='<FLOAT_SEL>'*::
Set window opacity. The window will no longer be eligible for automatic change in opacity upon focus change.

*border='<BOOL_SEL>'*::
Window should draw border.

*native-fullscreen='<BOOL_SEL>'*::
Window should enter native macOS fullscreen mode.

Expand All @@ -601,7 +575,6 @@ DATAFORMAT
"sticky": bool (optional),
"mouse_follows_focus": bool (optional),
"layer": string,
"border": bool (optional),
"native-fullscreen": bool (optional),
"grid": string
}
Expand Down
7 changes: 0 additions & 7 deletions examples/yabairc
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,6 @@ yabai -m config \
normal_window_opacity 0.90 \
window_opacity off \
insert_feedback_color 0xffd75f5f \
active_window_border_color 0xff775759 \
normal_window_border_color 0xff555555 \
window_border_width 4 \
window_border_radius 12 \
window_border_blur off \
window_border_hidpi on \
window_border off \
split_ratio 0.50 \
split_type auto \
auto_balance off \
Expand Down
Loading

0 comments on commit 5dd912f

Please sign in to comment.