Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radio: Use value instead of defaultValue #62

Merged
merged 2 commits into from
Jul 21, 2020
Merged

Conversation

RobinWijnant
Copy link
Member

No description provided.

@RobinWijnant RobinWijnant added the chore Making a script, doing a repeating task, refactor work label Jul 13, 2020
@RobinWijnant RobinWijnant self-assigned this Jul 13, 2020
Copy link
Contributor

@bramvanhoutte bramvanhoutte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have changed the working of the Radio buttons, so that the developer has to maintain the Radio state themselves. I agree with this change, but the documentation should be updated to reflect the new way of use.

@codecov
Copy link

codecov bot commented Jul 13, 2020

Codecov Report

Merging #62 into button-name-prop will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##           button-name-prop      #62      +/-   ##
====================================================
- Coverage             96.44%   96.42%   -0.03%     
====================================================
  Files                    12       12              
  Lines                   169      168       -1     
  Branches                 29       29              
====================================================
- Hits                    163      162       -1     
  Misses                    6        6              
Impacted Files Coverage Δ
src/components/Radio/RadioGroup/RadioGroup.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a83f06...b1a1724. Read the comment docs.

Base automatically changed from button-name-prop to master July 21, 2020 12:18
@RobinWijnant RobinWijnant merged commit 66ac738 into master Jul 21, 2020
@RobinWijnant RobinWijnant deleted the radio-value branch July 21, 2020 12:18
@github-actions
Copy link

🎉 This PR is included in version 1.5.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Making a script, doing a repeating task, refactor work released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants