remove test-id when no name is given

kodiak-packages · Aug 18, 2020 · f5ca8d4 · f5ca8d4
1 parent 13020cb
commit f5ca8d4
Show file tree

Hide file tree

Showing 6 changed files with 4 additions and 15 deletions.
diff --git a/src/components/Button/Button.tsx b/src/components/Button/Button.tsx
@@ -58,7 +58,7 @@ const Button: React.FC<Props> = ({
       type={htmlType}
       onClick={isLoading || suffixIcon ? undefined : onClick}
       name={name}
-      data-testid={`button-${name}`}
+      data-testid={name && `button-${name}`}
     >
       {isLoading ? <Spinner className={styles.spinner} /> : prefixIcon}
       <span className={labelClassNames}>{children}</span>

diff --git a/src/components/Button/__snapshots__/Button.test.tsx.snap b/src/components/Button/__snapshots__/Button.test.tsx.snap
@@ -21,7 +21,6 @@ exports[`Button default snapshot 1`] = `
 <DocumentFragment>
   <button
     class="ventura button typePrimary"
-    data-testid="button-undefined"
     type="button"
   >
     <span
@@ -68,7 +67,6 @@ exports[`Button prefix icon button 1`] = `
 <DocumentFragment>
   <button
     class="ventura button typePrimary"
-    data-testid="button-undefined"
     type="button"
   >
     <svg
@@ -99,7 +97,6 @@ exports[`Button secondary button 1`] = `
 <DocumentFragment>
   <button
     class="ventura button typeSecondary"
-    data-testid="button-undefined"
     type="button"
   >
     <span
@@ -115,7 +112,6 @@ exports[`Button suffix icon button 1`] = `
 <DocumentFragment>
   <button
     class="ventura button typePrimary"
-    data-testid="button-undefined"
     type="button"
   >
     <span

diff --git a/src/components/Input/Input.tsx b/src/components/Input/Input.tsx
@@ -56,7 +56,7 @@ const Input = React.forwardRef<HTMLInputElement, Props>(
         maxLength={maxLength}
         ref={ref}
         className={inputClassNames}
-        data-testid={`input-${name}`}
+        data-testid={name && `input-${name}`}
         onBlur={onBlur}
       />
     );

diff --git a/src/components/Table/TableRow/TableRow.tsx b/src/components/Table/TableRow/TableRow.tsx
@@ -18,7 +18,7 @@ const TableRow: React.FC<Props> = ({ className, children, onClick, name }: Props
   );
 
   return (
-    <tr onClick={onClick} className={tableClassNames} data-testid={`row-${name}`}>
+    <tr onClick={onClick} className={tableClassNames} data-testid={name && `row-${name}`}>
       {children}
     </tr>
   );

diff --git a/src/components/Table/__snapshots__/Table.test.tsx.snap b/src/components/Table/__snapshots__/Table.test.tsx.snap
@@ -27,7 +27,6 @@ exports[`Table default snapshot 1`] = `
     <tbody>
       <tr
         class="row"
-        data-testid="row-undefined"
       >
         <td
           class="cellAlignLeft cell"
@@ -47,7 +46,6 @@ exports[`Table default snapshot 1`] = `
       </tr>
       <tr
         class="row"
-        data-testid="row-undefined"
       >
         <td
           class="cellAlignLeft cell"
@@ -67,7 +65,6 @@ exports[`Table default snapshot 1`] = `
       </tr>
       <tr
         class="row"
-        data-testid="row-undefined"
       >
         <td
           class="cellAlignLeft cell"
@@ -87,7 +84,6 @@ exports[`Table default snapshot 1`] = `
       </tr>
       <tr
         class="row"
-        data-testid="row-undefined"
       >
         <td
           class="cellAlignLeft cell"
@@ -107,7 +103,6 @@ exports[`Table default snapshot 1`] = `
       </tr>
       <tr
         class="row"
-        data-testid="row-undefined"
       >
         <td
           class="cellAlignLeft cell"
@@ -127,7 +122,6 @@ exports[`Table default snapshot 1`] = `
       </tr>
       <tr
         class="row"
-        data-testid="row-undefined"
       >
         <td
           class="cellAlignLeft cell"
@@ -147,7 +141,6 @@ exports[`Table default snapshot 1`] = `
       </tr>
       <tr
         class="row"
-        data-testid="row-undefined"
       >
         <td
           class="cellAlignLeft cell"

diff --git a/src/components/TextArea/TextArea.tsx b/src/components/TextArea/TextArea.tsx
@@ -53,7 +53,7 @@ const TextArea = React.forwardRef<HTMLTextAreaElement, Props>(
         maxLength={maxLength}
         ref={ref}
         className={textareaClassNames}
-        data-testid={`textarea-${name}`}
+        data-testid={name && `textarea-${name}`}
         onBlur={onBlur}
       />
     );