Merge pull request #61 from kodiak-packages/button-name-prop

Add name prop to button
kodiak-packages · Jul 21, 2020 · 661e7f8 · 661e7f8
2 parents 9af70ad + 4bf2964
commit 661e7f8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/src/components/Button/Button.tsx b/src/components/Button/Button.tsx
@@ -53,6 +53,7 @@ const Button: React.FC<Props> = ({
       className={buttonClassNames}
       type={htmlType}
       onClick={isLoading || suffixIcon ? undefined : onClick}
+      name={name}
       data-testid={`button-${name}`}
     >
       {isLoading ? <Spinner className={styles.spinner} /> : prefixIcon}

diff --git a/src/components/Button/__snapshots__/Button.test.tsx.snap b/src/components/Button/__snapshots__/Button.test.tsx.snap
@@ -5,6 +5,7 @@ exports[`Button button should have type="submit" 1`] = `
   <button
     class="ventura button typePrimary"
     data-testid="button-test"
+    name="test"
     type="submit"
   >
     <span
@@ -38,6 +39,7 @@ exports[`Button loading button 1`] = `
     class="ventura button typePrimary"
     data-testid="button-loading"
     disabled=""
+    name="loading"
     type="button"
   >
     <svg