Fix segfault on several cores #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The path parameter is null according to the libretro API, but many cores expect the frontend to set this. We adopt this behavior to guard against noncompliant cores.
This was referenced Sep 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The segfaults occur because the core is trying to determine the ROM's base name from the path. However, when loading by memory, the libretro API says the path must be null. When noncompliant cores try to parse the null path, they segfault.
To fix this, we just set the path parameter even when loading by memory.
However, there is a potential problem: the libretro API says if path is set, it must be valid. But VFS paths are invalid, because cores can't load from Kodi's VFS. So this may cause cores to fail for ROMs on network drives.
Motivation:
Continued from libretro/beetle-gba-libretro#33.
How Has This Been Tested?
Test builds: Coming soon.
Tested on OSX with FCEUmm with local files.
Screenshots
FCEUmm no longer crashes: