-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(exoflex): Upgrade package @react-native-community/datetimepicker
& react-native-modal-datetime-picker
#716
chore(exoflex): Upgrade package @react-native-community/datetimepicker
& react-native-modal-datetime-picker
#716
Conversation
b52d2f5
to
331c0c3
Compare
It seems we have a problem in our circleci compare url orb, making the job failed without even running the test. After Josh (@ikusa) do some debugging, he told me it isn't worth pursuing this problem and better migrate this into github action. Since this is an urgent matter (DBO Needed this changes), I'm putting the succeeded local test in here as a prove this PR is ready to be merged and address the github action migration in separate PR test-exoflex.mp4 |
More background on the migrate suggestion We met a bug here where the path-filter which is an orb / package on circleci to run job based on file change throw exit code 1. This path filter are forked of god know who hosted on yoan circleci. I tried to take a look of what CircleCi offer for dynamic job run and turns out bit more complicated as we need config splitting to support this kind of process. Several reason why I think it's reasonable to move
Based on those reasoning I suggest we move from CircleCI |
const CustomHeaderComponent = () => ( | ||
<View style={styles.headerContainer}> | ||
<Text style={styles.headerTextStyle}>{title}</Text> | ||
</View> | ||
); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are creating this component on render, won't this component be recreated on every render? Though it's a simple component on a more complex component this would troublesome because I think it will keep remounting on every render. I'm not 100% sure though so maybe also need to test whether that will be the behavior?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I create simple sandbox here https://codesandbox.io/s/mutable-brook-z47g3z?file=/src/App.js:831-835 to test the my guess
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved in here: 3126579
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice changes
Changes:
@react-native-community/datetimepicker
from3.0.8
-->6.7.5
.react-native-modal-datetime-picker
from9.1.0
-->17.1.0
.headerTextIOS
and change it intocustomHeaderIOS
.The
headerTextIOS
changes was due to breaking changes inreact-native-modal-datetime-picker: v12.0.0
.Link Issue: https://github.com/mmazzarolo/react-native-modal-datetime-picker/releases/tag/v12.0.0
Solution: mmazzarolo/react-native-modal-datetime-picker#607