Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(exoflex): remove absolute positioning from switch's thumb #126

Merged
merged 1 commit into from
Oct 15, 2019
Merged

fix(exoflex): remove absolute positioning from switch's thumb #126

merged 1 commit into from
Oct 15, 2019

Conversation

darcien
Copy link
Contributor

@darcien darcien commented Oct 14, 2019

IDK when, but seems like our switch broke on the web because of the absolute positioning.

Before:
image

After:
image

oshimayoan
oshimayoan approved these changes Oct 14, 2019
View reviewed changes
Copy link
Contributor

@oshimayoan oshimayoan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it 🚢

@darcien darcien merged commit 43a3e4f into kodefox:master Oct 15, 2019
@darcien darcien deleted the fix/switch-offset branch October 15, 2019 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oshimayoan oshimayoan oshimayoan approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@darcien @oshimayoan @nathaniaelvina