fix(exoflex): change default font families to use system fonts #110
Conversation
| }, | ||
| }, | ||
| }, | ||
| default: { |
There was a problem hiding this comment.
Hmm, in our case, since we only support 3 platforms, default is equivalent to android I guess.
| weight: 'normal', | ||
| }, | ||
| bold: { | ||
| name: 'sans-serif-condensed', |
There was a problem hiding this comment.
Are you sure that condensed is the correct choice for bold?
By understanding that condensed is related to letter spacing, not font weight. Is this just the closest choice we have available on Android?
There was a problem hiding this comment.
I'm not 100% sure, since we don't have a bold one.
For sans-serif, this is what we got:
- sans-serif
- sans-serif-light
- sans-serif-thin
- sans-serif-condensed
- sans-serif-medium
I'll send a comparison tmr morning.
Maybe we can find a better bold font.
There was a problem hiding this comment.
Whoops, seems like the condensed one is not what I expected.
There was a problem hiding this comment.
This one is using sans-serif with fontWeight set to '700' for the bold one.
There was a problem hiding this comment.
Alternatively, we can just set the family to sans-serif and set the weight respectively instead of changing the family one by one.
There was a problem hiding this comment.
I think the alternative one is better.
Will resolve #95