-
-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ do not merge/arrowsquid ahp #9577
Conversation
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@vikiival, what are you waiting for here? |
If it is OK let's close it then |
@vikiival i'm only getting some console errors when accessing galleryitem, but everyhing is loading regardless |
Ah I forgot to enable ws, thanks for the test |
issue was in the trailing slash e73dc2a |
Code Climate has analyzed commit e73dc2a and detected 0 issues on this pull request. View more on Code Climate. |
Quality Gate passedIssues Measures |
Needs to be tested and then can be promoted to production? |
Exactly, once we close this PR i will promote arrowsquid to prod |
@vikiival i'm getting different query results: |
Probably fixed ? kudos to @daiagi |
putting it live? |
yup, this is fixed only small difference in query results now (21) items on explore -> items |
I am not sure what you mean. Can you provide screenshots please? |
Same as this, but with smaller difference |
I suppect there is a huge hidden bug in the token entity (cc @daiagi) I am wondering what should be the "correct" state tbh |
Should be some sql issue in the total token entity resolver, nothing major (in terms of effort to fix) |
Something completely different is going on here and it's not so easy to explain over gh post
let's walk through it, we will focus on Motifs collection
tl;dr some nfts have default image on canary and not default on PR env, which leads to a different count in explore page due to "stacked" cards @vikiival ant thoughts? my only idea is due to stuck indexer also, canary env does not impl yet the "tokenEntity" id change, that fixed "tokenEntity" bunching together nfts that should not be bunched together, that also leads to count mismatch |
Except this line I was able to understand the issue you have described above ^-^, thanks for the explanation. probably this would be a correct thing to do |
So @subsquid turned off the prod endpoint, so I will let this sync and promote it to prod |
Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type
Needs QA check
Context
Did your issue had any of the "$" label on it?
Screenshot 📸