Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ do not merge/arrowsquid ahp #9577

Closed
wants to merge 3 commits into from
Closed

Conversation

vikiival
Copy link
Member

  • 🔧 arrow stick AHP

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Needs QA check

  • @kodadot/qa-guild please review

Context

  • Closes #<issue_number>
  • Requires deployment <snek/rubick/worker>

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed UI

@vikiival vikiival requested a review from a team as a code owner February 28, 2024 20:15
@vikiival vikiival requested review from preschian and Jarsen136 and removed request for a team February 28, 2024 20:15
Copy link

netlify bot commented Feb 28, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit e73dc2a
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/65f29bc3f5b736000876a1b9
😎 Deploy Preview https://deploy-preview-9577--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@preschian preschian marked this pull request as draft February 29, 2024 07:09
@yangwao
Copy link
Member

yangwao commented Mar 12, 2024

@vikiival, what are you waiting for here?

@vikiival
Copy link
Member Author

@vikiival
Copy link
Member Author

If it is OK let's close it then

@prury
Copy link
Member

prury commented Mar 13, 2024

@vikiival i'm only getting some console errors when accessing galleryitem, but everyhing is loading regardless

image

image

@vikiival
Copy link
Member Author

Ah I forgot to enable ws, thanks for the test

@vikiival
Copy link
Member Author

issue was in the trailing slash e73dc2a

Copy link

codeclimate bot commented Mar 14, 2024

Code Climate has analyzed commit e73dc2a and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented Mar 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@yangwao
Copy link
Member

yangwao commented Mar 14, 2024

Needs to be tested and then can be promoted to production?

@vikiival
Copy link
Member Author

Needs to be tested and then can be promoted to production?

Exactly, once we close this PR i will promote arrowsquid to prod

@prury
Copy link
Member

prury commented Mar 19, 2024

@vikiival i'm getting different query results:

image

@vikiival
Copy link
Member Author

@vikiival i'm getting different query results:

I have missed the PR from @daiagi

Should be fixed in ~30 min

@prury
Copy link
Member

prury commented Mar 21, 2024

@vikiival

image

@vikiival
Copy link
Member Author

Probably fixed ?

kudos to @daiagi
Screenshot 2024-03-22 at 13 52 17

@yangwao
Copy link
Member

yangwao commented Mar 22, 2024

putting it live?

@prury
Copy link
Member

prury commented Mar 22, 2024

Probably fixed ?

kudos to @daiagi Screenshot 2024-03-22 at 13 52 17

yup, this is fixed

only small difference in query results now (21) items on explore -> items

@vikiival
Copy link
Member Author

only small difference in query results now (21) items on explore -> items

I am not sure what you mean. Can you provide screenshots please?

@prury
Copy link
Member

prury commented Mar 22, 2024

@vikiival i'm getting different query results:

image

Same as this, but with smaller difference

@vikiival
Copy link
Member Author

vikiival commented Mar 22, 2024

Same as this, but with smaller difference

I suppect there is a huge hidden bug in the token entity (cc @daiagi)

I am wondering what should be the "correct" state tbh

@daiagi
Copy link
Contributor

daiagi commented Mar 22, 2024

Should be some sql issue in the total token entity resolver, nothing major (in terms of effort to fix)
Can assume that previously number is the correct one as I checked it well when I first wrote it. And the previous query was simple

@daiagi
Copy link
Contributor

daiagi commented Mar 23, 2024

Something completely different is going on here and it's not so easy to explain over gh post

  1. it isn't related to tokenEntity at all, and token entity is reporting correct numbers (compare PR and canary with "the break" search query)

  2. it's about metadata mismatch between canary and pr env. no idea why. maybe because the indexer is stuck?

let's walk through it, we will focus on Motifs collection

  1. in explore page, search for "motifs"
  2. notice that count@pr = count@canary +4
  3. scroll to bottom and find a stacked nft with countof 8@canary and count of 4@PR. this account for all the mismatch
  4. go to collection page (of motifs), collection page does not use TokenEntity at all, notice that total count is same in both envs
  5. manually count the amount of stacked nfts, you will find that the count on the "stacked" card was individually correct in each env
  6. think to yourself wtf?
  7. find out that nft 108-88, shows the default drop picture on canary (stacked) and NOT the default picture on PR env (not stacked)

image

tl;dr

some nfts have default image on canary and not default on PR env, which leads to a different count in explore page due to "stacked" cards @vikiival ant thoughts? my only idea is due to stuck indexer

also, canary env does not impl yet the "tokenEntity" id change, that fixed "tokenEntity" bunching together nfts that should not be bunched together, that also leads to count mismatch

@vikiival
Copy link
Member Author

also, canary env does not impl yet the "tokenEntity" id change, that fixed "tokenEntity" bunching together nfts that should not be bunched together, that also leads to count mismatc

Except this line I was able to understand the issue you have described above ^-^, thanks for the explanation.

probably this would be a correct thing to do

@vikiival
Copy link
Member Author

So @subsquid turned off the prod endpoint, so I will let this sync and promote it to prod

@vikiival
Copy link
Member Author

photo_2024-03-29 13 59 48

@vikiival
Copy link
Member Author

Side effects are my favs

Screenshot 2024-03-29 at 14 07 01

@vikiival vikiival closed this Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants