Fix issue with global var for Vue 2 #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for your work on this component! I'm still using Vue 2 and have trouble getting it to run with VuePress, presumably because of this issue with the global var that has been fixed for v2.0.0. Can we backport this for v1? That would be amazing!
|
Hey @tillsanders, thanks for the PR. Tomorrow evening i will merge this and release a new version. Ok? |
|
@koca That would be a dream! 😍 |
|
Hey @tillsanders, i've just released |
|
Amazing! Thank you so much, that was fast! I've already integrated it in my project, the OpenElectionCompass ;)
|
|
Just checked OpenElectionsCompass and it's a great work! Maybe i should add a section to the readme to show cool projects like yours :) anyway cheers 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your work on this component! I'm still using Vue 2 and have trouble getting it to run with VuePress, presumably because of this issue with the global var that has been fixed for v2.0.0. Can we backport this for v1? That would be amazing!