Remove legacy contextTypes #4997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes some legacy api deprecation notices in the console in
React 18.
- Replace the last this.context.router in projectSettings.es6 with
this.props.router from withRouter HOC. (Tested this, works fine)
- Remove these, which are unused:
SomeComponent.contextTypes = {
router: PropTypes.object
};
p2edwards
added
dependencies
Doing this step in one commit, hoping it will make the diff easier to review online.
e.g., not say 'duplicate import' for this code:
import React from 'react'
import type { ReactNode } from 'react'
…which used to work fine, but typescript-eslint's no-duplicate-imports
rule has been removed:
- typescript-eslint/typescript-eslint@47eeea9275bd
- https://typescript-eslint.io/rules/no-duplicate-imports/
We could do more with this plugin.
Only skimmed it, but some of the other features might require some
more config.
- https://github.com/import-js/eslint-plugin-import/blob/main/README.md#resolvers
(Meanwhile, I'll try not to think about how many dev dependencies
we bring in just for this cool rule.)
- Remove modifier='[object Object]' in generated bem elements - Use the new React 18 root API in renderInBackbone
13 tasks
Update ESLint config to accept separate type imports in TS again
magicznyleszek
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove remnants of legacy Context API usage that was causing React 18 to show deprecation warnings in the developer console. Also removes the 'prop-types' library and converts the reactCreateBemElement function to TypeScript.
Notes for reviewer
This PR
More info:
Test this:
Checklist
Related issues
Follow-up to #4992