Monotonicspline #710
Merged
Monotonicspline #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matekadlicsko
force-pushed
the
monotonicspline
branch
from
2044560 to
f601bc6
Compare
koaning
approved these changes
Nov 6, 2024
koaning
added a commit
that referenced
this pull request
Nov 12, 2024
* first version * add-tests * docs * iterp for the win * docs * reran-plot-script * gogo * fixed-tests * gogo * Monotonicspline (#710) * fix: fixed an error in the implementation * feat: tests now directly test monotonicity and boundedness --------- Co-authored-by: Mate Kadlicsko <[email protected]> * update-docs * base-tests * remove 3.8 * Update sklego/preprocessing/monotonicspline.py Co-authored-by: Francesco Bruzzesi <[email protected]> * Apply suggestions from code review Co-authored-by: Francesco Bruzzesi <[email protected]> * Update docs/_scripts/preprocessing.py * review * print check * prints-fixed * Update sklego/preprocessing/monotonicspline.py Co-authored-by: Francesco Bruzzesi <[email protected]> --------- Co-authored-by: mate.kadlicsko <[email protected]> Co-authored-by: Mate Kadlicsko <[email protected]> Co-authored-by: Francesco Bruzzesi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed one thing in the implementation of
MonotonicSplineTransformer.Added tests directly checking:
Fixes #(issue)
Type of change
Checklist: