Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable GroupedTransformer.set_output(..) #697

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Conversation

FBruzzesi
Copy link
Collaborator

@FBruzzesi FBruzzesi commented Aug 19, 2024

Description

Custom logic to define get_feature_names_out for GroupedTransformer class and therefore enable set_output.

Closes #696

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines (ruff)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (also to the readme.md)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added tests to check whether the new feature adheres to the sklearn convention
  • New and existing unit tests pass locally with my changes

@FBruzzesi
Copy link
Collaborator Author

@koaning tests failing seem unrelated

@FBruzzesi FBruzzesi changed the title feat: enable GroupedTransformer().set_output(..) feat: enable GroupedTransformer.set_output(..) Aug 20, 2024
@koaning koaning merged commit 89d1da6 into main Aug 21, 2024
14 of 18 checks passed
@koaning
Copy link
Owner

koaning commented Aug 21, 2024

Indeed, mhm. I will have a quick look at that. I think we can drop that test, mainly because OpenML can be flaky. This PR looks good though so I will merge it right away!

@koaning koaning deleted the feat/set-output branch August 21, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Enable GroupedTransformer to work with .set_output(transform="pandas")
2 participants