WIP: unittests speedup #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koaning
approved these changes
Dec 28, 2023
There was a problem hiding this comment.
Hah! Interesting, I remember getting to a similar conclusion a few years ago when I tried making these tests faster. I wrote pytest duration insights for a use-case at Rasa which I then ran on this codebase. But yeah, making UMAP tests a bunch faster is an easy accept in my book.
|
Love to hear that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I was playing around for some features and while iterating I was getting bored of waiting for tests.
Thus running
pytest . --durations 30 --disable-warningsI could get the most time consuming tests.The code changes keep the same level of coverage but lower the runtime.
I opened a PR in my own fork to quantify the difference and it is quite nice (4m 14s vs last merge here of 7m 37s).
I didn't investigate much further, but since it was a bit relevant for me I wanted to share it.