list -> numpy constant creation

koaning · Aug 7, 2024 · 9437a0a · 9437a0a
1 parent 0ba28c7
commit 9437a0a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/sklego/meta/grouped_predictor.py b/sklego/meta/grouped_predictor.py
@@ -153,7 +153,7 @@ def __add_shrinkage_column(self, frame, groups=None):
 
             frame = frame.select(
                 nw.from_dict(
-                    data={self._global_col_name: [self._global_col_value] * n_samples},
+                    data={self._global_col_name: np.full(shape=n_samples, fill_value=self._global_col_value)},
                     native_namespace=nw.get_native_namespace(frame),
                 )[self._global_col_name],
                 nw.all(),

diff --git a/sklego/meta/hierarchical_predictor.py b/sklego/meta/hierarchical_predictor.py
@@ -283,7 +283,7 @@ def fit(self, X, y=None):
 
         native_namespace = nw.get_native_namespace(X)
         target_series = nw.from_dict({self._TARGET_NAME: y}, native_namespace=native_namespace)[self._TARGET_NAME]
-        global_series = nw.from_dict({self._GLOBAL_NAME: [1] * n_samples}, native_namespace=native_namespace)[
+        global_series = nw.from_dict({self._GLOBAL_NAME: np.ones(n_samples)}, native_namespace=native_namespace)[
             self._GLOBAL_NAME
         ]
         frame = X.with_columns(
@@ -322,7 +322,7 @@ def _predict_estimators(self, X, method_name):
 
         n_samples = X.shape[0]
         native_namespace = nw.get_native_namespace(X)
-        global_series = nw.from_dict({self._GLOBAL_NAME: [1] * n_samples}, native_namespace=native_namespace)[
+        global_series = nw.from_dict({self._GLOBAL_NAME: np.ones(n_samples)}, native_namespace=native_namespace)[
             self._GLOBAL_NAME
         ]