-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ctx.wrappers array #694
Conversation
Copied from another conversation: If we implement this, I'd be in favor of removing the deprecated generator to promise conversion in favor of |
also see koajs/compose#51 |
b582f04
to
3529d0b
Compare
Codecov Report
@@ Coverage Diff @@
## master #694 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 4 4
Lines 431 432 +1
Branches 103 103
=====================================
+ Hits 431 432 +1
Continue to review full report at Codecov.
|
would really love more people to express their opinions, otherwise, I'm inclined to just merge it! |
This and #707 preform the same purpose different ways, so only one should be merged. Do you prefer this one? |
I'll just close this as it has little relevance today IMO. Maybe there's still a need for wrappers but I doubt it personally and the same functionality can be approached in user land. Also, over the years I haven't really seen any requests for wrappers. If I remember correctly, this was brought to light due to TJ's original issue to simplify mw profiling, though today this can be solved with async_hooks which seems more like native approach Koa should aim towards. Please reopen if I'm wrong :) |
Goes along with koajs/compose#52.