Revert "fix: Calling all options even if origin header is not present (…

…#87)" This reverts commit 2e8da5b.
koajs · Oct 8, 2022 · 208b86c · 208b86c
1 parent d5456f7
commit 208b86c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/index.js b/index.js
@@ -58,6 +58,8 @@ module.exports = function(options) {
     // https://github.com/rs/cors/issues/10
     ctx.vary('Origin');
 
+    if (!requestOrigin) return await next();
+
     let origin;
     if (typeof options.origin === 'function') {
       origin = await options.origin(ctx);

diff --git a/test/cors.test.js b/test/cors.test.js
@@ -77,14 +77,6 @@ describe('cors.test.js', function() {
         .expect({ foo: 'bar' })
         .expect(200, done);
     });
-
-    it('should always set `Access-Control-Allow-Origin` to *, even if no Origin is passed on request', function(done) {
-      request(app.listen())
-        .get('/')
-        .expect('Access-Control-Allow-Origin', '*')
-        .expect({ foo: 'bar' })
-        .expect(200, done);
-    });
   });
 
   describe('options.secureContext=true', function() {