Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set @types/cobody as a dependency #164

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

samchungy
Copy link

@samchungy samchungy commented Sep 28, 2024

To switch to @koa/bodyparser we have to awkwardly declare a dependency on @types/cobody or resort to using skipLibCheck as this library is referencing types it whilst declaring it as a devDependency.

This PR sets @types/cobody as a dependency.

Checklist

  • I have ensured my pull request is not behind the main or master branch of the original repository.
  • I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • I have written a commit message that passes commitlint linting.
  • I have ensured that my code changes pass linting tests.
  • I have ensured that my code changes pass unit tests.
  • I have described my pull request and the reasons for code changes along with context if necessary.

@samchungy samchungy marked this pull request as ready for review September 28, 2024 10:16
@samchungy samchungy changed the title Set @types/cobody as a dependency fix: set @types/cobody as a dependency Sep 29, 2024
@samchungy
Copy link
Author

@3imed-jaberi, @fengmk2 @titanism Could you please take a look? Cheers 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant