Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support xml #131

Merged
merged 2 commits into from
Mar 24, 2020
Merged

feat: support xml #131

merged 2 commits into from
Mar 24, 2020

Conversation

atian25
Copy link
Contributor

@atian25 atian25 commented Mar 3, 2020

only parse xml as text to ctx.request.body, not try to parse it with xml lib.

dead-horse
dead-horse reviewed Mar 3, 2020
View reviewed changes
index.js
@@ -59,15 +60,23 @@ module.exports = function (opts) {
'text/plain',
];

// default xml types
var xmlTypes = [
'text/xml',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

默认先不开启吧，作为一个可选项打开。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enableTypes 里面没有 xml，所以不是默认打开的。

@dead-horse dead-horse merged commit 705673d into koajs:master Mar 24, 2020
@atian25 atian25 deleted the xml branch March 24, 2020 05:45
@1pete 1pete mentioned this pull request Oct 20, 2021
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dead-horse dead-horse dead-horse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atian25 @dead-horse