Build ko for Windows #339
Merged
Build ko for Windows #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also explicitly build for macOS (darwin), I'm not sure how that was being done before.
Codecov Report
@@ Coverage Diff @@
## main #339 +/- ##
=======================================
Coverage 38.24% 38.24%
=======================================
Files 33 33
Lines 1527 1527
=======================================
Hits 584 584
Misses 849 849
Partials 94 94 Continue to review full report at Codecov.
|
jonjohnsonjr
approved these changes
Apr 15, 2021
jonjohnsonjr
approved these changes
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also explicitly build for macOS (darwin), I'm not sure how that was being done before.