Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two changes that should make publishing faster.
The first is bumping ggcr to pull in google/go-containerregistry#1633. This allows us to use the new
remote.Pusher
API, which better handles deduplication of token handshakes, blob uploads, and manifest uploads concurrently and safely.The second is bumping cosign to pull in sigstore/cosign#2878. This allows users to set
SOURCE_DATE_EPOCH
in order to get reproducible SBOMs, which allows us to skip uploading them and also avoids generating a ton of unused SBOMs when re-uploading the same thing (e.g. in a tight development loop).For a NOP
ko build --platform=all
(taking advantage of bothSOURCE_DATE_EPOCH
andKO_CACHE
), we finish in ~1/4 the time.Before:
After:
Even in non-NOP cases, the publisher leg should be quite a bit faster, but I am too lazy to measure those.