Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
106495: sql: deflake TestParallel r=koorosh a=koorosh

This change is attempt to fix flakiness of TestParallel test with following updates:
- increased `range max bytes` setting as it was increased in a37e053.
- disabled automatic stats collection for system tables, it has be done in addition to already disabled `stats.AutomaticStatisticsClusterMode`
 setting.

Resolves: cockroachdb#101614

Release note: None

Co-authored-by: Andrii Vorobiov <[email protected]>
  • Loading branch information
craig[bot] and koorosh committed Jul 11, 2023
2 parents f0cd18b + 80b6cde commit cc97c06
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions pkg/sql/logictest/parallel_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,8 @@ func (t *parallelTest) setup(ctx context.Context, spec *parTestSpec) {
sql.DistSQLClusterExecMode.Override(ctx, &st.SV, int64(mode))
// Disable automatic stats - they can interfere with the test shutdown.
stats.AutomaticStatisticsClusterMode.Override(ctx, &st.SV, false)
stats.UseStatisticsOnSystemTables.Override(ctx, &st.SV, false)
stats.AutomaticStatisticsOnSystemTables.Override(ctx, &st.SV, false)
}

t.clients = make([][]*gosql.DB, spec.ClusterSize)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

cluster_size: 3

range_split_size: 32768
range_split_size: 67108864

run:
# First run setup
Expand Down

0 comments on commit cc97c06

Please sign in to comment.