Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

baseDir as array and added output wrapper #10

Merged
merged 8 commits into from
Mar 19, 2014
Merged

baseDir as array and added output wrapper #10

merged 8 commits into from
Mar 19, 2014

Conversation

helly0d
Copy link
Contributor

@helly0d helly0d commented Mar 19, 2014

I have changed a bit of the code and added some features.

  • the baseDir parameter can now be either a string or an array of strings.
  • added wrapper parameter which allows you to wrap your code.
  • changed the behavior of the paths. everything now is relative to the directory of the JSON. This is something useful if you have 5 projects, each one with it's own configuration JSON.

P.S. I hope i haven't messed up the code too much, because my Eclipse is not yet set to auto-format the JAVA files as it should and also because i haven't used git to actually clone the repository and work locally.

P.P.S. Please also make an executable jar with each pull in master, because the current jar still has that issue of having path resolution problems, and i could say that this is the reason i forked the project ( i mean until now i hadn't even had a github account 😄 )

knyga added a commit that referenced this pull request Mar 19, 2014
baseDir as array and added output wrapper
@knyga knyga merged commit d9dec52 into knyga:master Mar 19, 2014
@knyga
Copy link
Owner

knyga commented Mar 19, 2014

Thanks

@helly0d
Copy link
Contributor Author

helly0d commented Mar 20, 2014

I should thank you because i started to get sick of being dependent of the goog.require and goog.base. Also as an idea, try to use @requires instead of @Depends so that you could document the js code using JSdoc-toolkit https://code.google.com/p/jsdoc-toolkit/wiki/TagRequires

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants