Group radio buttons when setting query parameters #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed value is added Radio buttons would call `_.set` for each of them, meaning that the value of the parameter would always be the set to the same as the last added. With this change, the selected value is set instead.
shalvah
requested changes
Sep 2, 2021
shalvah
approved these changes
Sep 2, 2021
shalvah
reviewed
Sep 2, 2021
| @@ -178,6 +178,21 @@ async function executeTryOut(endpointId, form) { | |||
| const query = {}; | |||
| const queryParameters = form.querySelectorAll('input[data-component=query]'); | |||
| queryParameters.forEach(el => _.set(query, el.name, el.value)); | |||
There was a problem hiding this comment.
You know, I think this would have just been simpler:
queryParameters.forEach(el => {
if (el.type !== 'radio' || (el.type === 'radio' && el.checked)) {
_.set(query, el.name, el.value);
}
});I'll change it. Simpler is better. 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Radio buttons would call
_.setfor each of them, meaning that the value of the parameter would always be the set to the same as the last added. (falsein the case ofbooleanvalidations)With this change, the selected value is set instead.