Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UseApiResourceTags (fix invalid type error) #235

Merged
merged 1 commit into from
Jun 8, 2021
Merged

Update UseApiResourceTags (fix invalid type error) #235

merged 1 commit into from
Jun 8, 2021

Conversation

yaroslawww
Copy link
Contributor

This comment:

* @apiResource 201 \App\Http\Resources\Advertisers\UserManagement\StaffResource

Throw error:

 Spatie\DataTransferObject\DataTransferObjectError 
 Invalid type: expected `Knuckles\Camel\Extraction\Response::status` to be of type `integer`, instead got value `201`, which is string..

So, to fix the added cast to integer status

This comment:
```
* @apiResource 201 \App\Http\Resources\Advertisers\UserManagement\StaffResource
```
Throw error:
```
 Spatie\DataTransferObject\DataTransferObjectError 
 Invalid type: expected `Knuckles\Camel\Extraction\Response::status` to be of type `integer`, instead got value `201`, which is string..
```
So, to fix the added cast to integer status
@shalvah
Copy link
Contributor

shalvah commented Jun 8, 2021

Thanks. Will likely need to make the same changes for Transformers too. But what's with the I other changes files?

@yaroslawww
Copy link
Contributor Author

@shalvah

In my case, only this problem gives an error. I am wary of making any changes to the transformers.

In index.blade.php, only the path to the assets files has been changed, since by default there is "../docs/" but in order not to publish the template and not change it, it is convenient to just use the relative path "./"

@shalvah
Copy link
Contributor

shalvah commented Jun 8, 2021

Alright, please remove the template changes from the PR, so I can merge. I don't really get your explanation, and it should be a separate PR, btw.

@yaroslawww
Copy link
Contributor Author

@shalvah Done

@shalvah shalvah merged commit c9b34a5 into knuckleswtf:master Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants