Exit with non-success code if there are warnings

knuckleswtf · Nov 18, 2022 · 67b77cb · 67b77cb
1 parent 0b9473b
commit 67b77cb
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 7 deletions.
diff --git a/phpunit.xml b/phpunit.xml
@@ -20,6 +20,9 @@
             <file>src/ScribeServiceProvider.php</file>
         </exclude>
     </coverage>
+    <php>
+        <server name="SCRIBE_TESTS" value="1" />
+    </php>
     <testsuites>
         <testsuite name="Full Test">
             <file>tests/GenerateDocumentation/OutputTest.php</file>

diff --git a/src/Commands/GenerateDocumentation.php b/src/Commands/GenerateDocumentation.php
@@ -66,14 +66,9 @@ public function handle(RouteMatcherInterface $routeMatcher, GroupedEndpointsFact
         $writer = new Writer($this->docConfig, $this->configName);
         $writer->writeDocs($groupedEndpoints);
 
-        if ($groupedEndpointsInstance->hasEncounteredErrors()) {
-            c::warn('Generated docs, but encountered some errors while processing routes.');
-            c::warn('Check the output above for details.');
-        }
-
         $this->upgradeConfigFileIfNeeded();
 
-        $this->sayGoodbye();
+        $this->sayGoodbye(errored: $groupedEndpointsInstance->hasEncounteredErrors());
     }
 
     public function isForcing(): bool
@@ -187,7 +182,7 @@ protected function upgradeConfigFileIfNeeded(): void
 
     }
 
-    protected function sayGoodbye(): void
+    protected function sayGoodbye(bool $errored = false): void
     {
         $message = 'All done. ';
         if ($this->docConfig->get('type') == 'laravel') {
@@ -200,5 +195,13 @@ protected function sayGoodbye(): void
 
         $this->newLine();
         c::success($message);
+
+        if ($errored) {
+            c::warn('Generated docs, but encountered some errors while processing routes.');
+            c::warn('Check the output above for details.');
+            if (empty($_SERVER["SCRIBE_TESTS"])) {
+                exit(2);
+            }
+        }
     }
 }