-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JRuby support that is not a no-op #7
Comments
As far as I can tell there is no active repository for the |
Ping again... in order for this gem to support JRuby natively, so we can remove our built-in SortedSet, the following tasks need to happen:
I would be willing to work with some of our contributors to implement a JRuby-native rbtree, but the repository issue needs to be fixed first. The sorted_set gem should not depend on rbtree unless there's a public rbtree repository somewhere. |
Ping again. We have outstanding work items to remove our sorted set implementation but we can't until this gem directly supports JRuby. I have listed the two possible options in the description. Can you help us? |
@hsbt is there anything you can do to help move this forward? It still depends on the rbtree gem that does not have a public repository. I don't think this is a good situation. |
@headius pong. Thanks for your mention. At first, I'm understanding this issue. |
@hsbt The main problem is that this gem depends on the rbtree gem which has no public sources anymore (old repository was on RubyForge). The secondary problem is JRuby support: we could add what we have (using JDK classes) or add JRuby support to rbtree if the sources were made public again. |
Another release of JRuby will go out this week without being able to remove SortedSet from our core. We still need access to the rbtree sources in order to support the sorted_set gem. |
I am bumping this again from JRuby 9.4.3 to 9.4.4. We would still like to be able to support this gem but the following needs to happen:
|
|
@hsbt Thank you! I will try to add JRuby support. |
When complete this will resolve knu/sorted_set#7 ConcurrentRBTree imported from https://github.com/JuanBesa/Concurrent-RedBlack-Tree
JRuby would like to support this gem directly (rather than passively), but currently it has a dependency on the
rbtree
gem which has a C extension.First off, thanks very much for thinking of JRuby and releasing
-java
versions of the gem that do not have therbtree
dependency and that just utilize our existingSortedSet
implementation! We appreciate your consideration!We do, however, want to match CRuby and stop shipping our own implementation of
SortedSet
, so I see two options going forward:SortedSet
inside the-java
version of thesorted_set
gem.-java
version of therbtree
gem and enable your version ofSortedSet
on JRuby.We would prefer to do the latter, for ease of maintenance, but I thought we should start the discussion here.
There may be performance considerations... the existing JRuby
SortedSet
is based on the JDK'sTreeSet
class, which has been optimized for this purpose.Copying @kares as he did the native port of the
set
library in JRuby.The text was updated successfully, but these errors were encountered: