Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#hash and #eql? are broken because RBTree does not implement them #3

Open
jaynetics opened this issue Jan 8, 2021 · 2 comments
Open

#hash and #eql? are broken because RBTree does not implement them #3

jaynetics opened this issue Jan 8, 2021 · 2 comments

Comments

@jaynetics
Copy link

jaynetics commented Jan 8, 2021 •
edited
Loading

on Ruby 2.7:

require 'set'
SortedSet[1].eql?(SortedSet[1]) # => true

on Ruby 3.0:

require 'sorted_set'
SortedSet[1].eql?(SortedSet[1]) # => false

similar to #2, this could be fixed here via an override, but rbtree3 rbtree seems more like the correct place.
jaynetics added a commit to jaynetics/character_set that referenced this issue Jan 11, 2021
@jaynetics
Work around broken #eql?, #hash in gemified sorted_set
a077b62 
knu/sorted_set#3
@dleidert
Copy link

dleidert commented Nov 28, 2021 •
edited
Loading

This issue causes the hamster gem's tests to fail: hamstergem/hamster#251

@dleidert dleidert mentioned this issue Nov 28, 2021
Closed
@alexdowad
Copy link

alexdowad commented Nov 28, 2021 •
edited
Loading

This issue causes the hamster gem's tests to fail: hamstergem/hamster#251

I just found my way here while investigating the same issue 😄

@alexdowad alexdowad mentioned this issue Nov 28, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexdowad @jaynetics @dleidert