Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding instructions for installing as an Ember addon #47

Merged
merged 2 commits into from
Jun 24, 2016

Conversation

dhall
Copy link
Contributor

@dhall dhall commented Jun 24, 2016

I'm not yet familiar enough with the Ember ecosystem to know if the npm install instructions are outdated or still valid so I left in place. Great project -- thanks for sharing your work.

@knownasilya
Copy link
Owner

Ah good catch, forgot that was there. You can remove the old instructions.

@knownasilya knownasilya merged commit bc18b81 into knownasilya:master Jun 24, 2016
knownasilya pushed a commit that referenced this pull request Oct 25, 2016
- docs: Add instructions for installation, see #47
- fix(docs): change on/offValue to on/offLabel, see #50
- fix(tests): Add ember-alpha
- fix(deprecation): Replace `contains` with `includes`, see #53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants