Curious where the magic number 375 comes from?

[innerexception]

No description provided.

[benwebbbenwebb]

I'm pretty sure it's based on the "screen size" width of a portrait iPhone 6 (or 7): http://www.kylejlarson.com/wp-content/uploads/2015/02/iphone-6-screen-size.jpg

From: http://www.kylejlarson.com/blog/iphone-6-screen-size-web-design-tips/

[knowbody]

exactly that, which like you said it is a bit magical and it shouldn't be, hence #1. I never actually had a time to explore this further and the component work fine for my use case. However at the moment it's not ideal for all of the phone screens sizes.

[thibautguedou3]

Could it be possible to pass this value in an optional prop deviceWidthBase and use the 375 as a default prop value? It will make this way more customizable

[knowbody]

Of course! Feel free to send the PR

…

On Fri, 21 Dec 2018 at 16:57, thibautguedou3 ***@***.***> wrote: Could it be possible to pass this value in an optional prop deviceWidthBase and use the 375 as a default prop value? It will make this way more customizable — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#8 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADoDp4SUST0QYE96kx9dSgP8BbbPljWjks5u7QTWgaJpZM4PfqQF> .

[thibautguedou3]

Of course! Feel free to send the PR
…
On Fri, 21 Dec 2018 at 16:57, thibautguedou3 @.***> wrote: Could it be possible to pass this value in an optional prop deviceWidthBase and use the 375 as a default prop value? It will make this way more customizable — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#8 (comment)>, or mute the thread https://github.com/notifications/unsubscribe-auth/ADoDp4SUST0QYE96kx9dSgP8BbbPljWjks5u7QTWgaJpZM4PfqQF .

#14 :)