fix: use jsx classic runtime to avoid issues on react < 18 #115
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using React < 18 users will run into this error:
The issue is described in this thread: facebook/react#20235
The fix was implemented in React 18, but the only "fixes" that exist if we're using the JSX runtime are to patch webpack configs, which is not great.
Instead, this PR implements an option to use the "classic" JSX runtime, which is the
createElement
API as a workaround so thatreact/jsx-runtime
is never referenced. To do so, we also needed to ensure thatimport React from "react"
was at the top of all of our JSX components, which is what thebabel-plugin-require-react
does.I tested this locally in our example apps with a build and everything works