Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smallest icon size is shifted in IE11 #144

Closed
rbu opened this issue Oct 13, 2015 · 4 comments · Fixed by #190
Closed

Smallest icon size is shifted in IE11 #144

rbu opened this issue Oct 13, 2015 · 4 comments · Fixed by #190
Labels
PR welcomed

Comments

@rbu
Copy link
Contributor

rbu commented Oct 13, 2015

Steps to reproduce:

  1. Open latest IE11
  2. Go to http://kurtnoble.com/labs/rrssb/
  3. Set window size as small as possible

rrsb
@rbu
Copy link
Contributor Author

rbu commented Oct 13, 2015

The span containing the svg is missing a height declaration (thus has height: auto) and for some reason this means that the ul's height is not getting pushed all the way inside. As a workaround, this helps (and may be the solution?):

.tiny-format .rrssb-icon {
    height: 100%;
}

@dbox
Copy link
Contributor

dbox commented Dec 8, 2015

Good catch! Looking into this.

@dbox
Copy link
Contributor

dbox commented Oct 14, 2016

@rbu Want to try a PR for this?

rbu added a commit to rbu/rrssb that referenced this issue Oct 17, 2016
@rbu
Declare a min-height for tiny icon variant
c9e959d 
This fixes a shifting effect in IE11, not visible in Edge or other
modern browsers. Fixes kni-labs#144
@rbu rbu mentioned this issue Oct 17, 2016
Merged
@rbu
Copy link
Contributor Author

rbu commented Oct 17, 2016

Sure, sent one.

@dbox dbox closed this as completed in #190 Oct 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
PR welcomed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Declare a min-height for tiny icon variant rbu/rrssb
2 participants
@rbu @dbox