Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update boskos flags #658

Merged
merged 2 commits into from
Apr 2, 2019
Merged

update boskos flags #658

merged 2 commits into from
Apr 2, 2019

Conversation

steuhs
Copy link
Contributor

@steuhs steuhs commented Apr 1, 2019 •
edited
Loading

Fixes #638

@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 1, 2019
@steuhs steuhs requested a review from adrcunha April 1, 2019 20:48
@steuhs steuhs mentioned this pull request Apr 1, 2019
Closed
adrcunha
adrcunha suggested changes Apr 2, 2019
View reviewed changes
ci/prow/boskos/config.yaml Outdated Show resolved Hide resolved
@steuhs
use images that exists
7528a7b 
also the most recent ones with the same tags
@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 2, 2019
@steuhs steuhs changed the title update boskos images and flags update boskos flags Apr 2, 2019
@knative-prow-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrcunha, steuhs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adrcunha
Copy link
Contributor

adrcunha commented Apr 2, 2019

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2019
@knative-prow-robot knative-prow-robot merged commit d3bec29 into knative:master Apr 2, 2019
Cynocracy pushed a commit to Cynocracy/test-infra that referenced this pull request Jun 13, 2020
@Harwayne @knative-prow-robot
JSONTrace returns a structured object, not just a string. (knative#658)
343f164 
* JSONTrace returns a structured object, not just a string.

* Fix usage in spoof.go.

* Update test/zipkin/util.go

Co-Authored-By: Victor Agababov <[email protected]>

* Update test/zipkin/util.go

Co-Authored-By: Victor Agababov <[email protected]>

* PR comments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrcunha adrcunha adrcunha approved these changes

@chaodaiG chaodaiG Awaiting requested review from chaodaiG

@ericKlawitter ericKlawitter Awaiting requested review from ericKlawitter

Assignees

@adrcunha adrcunha

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@steuhs @knative-prow-robot @adrcunha