Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update boskos version #647

Merged
merged 2 commits into from
Mar 29, 2019
Merged

update boskos version #647

merged 2 commits into from
Mar 29, 2019

Conversation

steuhs
Copy link
Contributor

@steuhs steuhs commented Mar 29, 2019

The existing one is pretty outdated and may lead to the issue here #638

Fixes #

The existing one is pretty outdated and may lead to the issue here #638
@steuhs steuhs requested a review from adrcunha March 29, 2019 18:18
@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 29, 2019
Copy link
Contributor

@adrcunha adrcunha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update reaper and janitor.

@knative-prow-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrcunha, steuhs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adrcunha
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2019
@knative-prow-robot knative-prow-robot merged commit 3071d77 into master Mar 29, 2019
@adrcunha adrcunha deleted the steuhs-patch-1 branch April 17, 2019 16:46
Cynocracy pushed a commit to Cynocracy/test-infra that referenced this pull request Jun 13, 2020
Produced via:
  `gofmt -s -w $(find -path './vendor' -prune -o -type f -name '*.go' -print))`
  `goimports -w $(find -name '*.go' | grep -v vendor)`
/assign mattmoor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants