Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HoldTillRename: Rename knative-sandbox to knative-extension #3837

Closed
wants to merge 4 commits into from
Closed

HoldTillRename: Rename knative-sandbox to knative-extension #3837

wants to merge 4 commits into from

Conversation

davidhadas
Copy link
Contributor

@davidhadas davidhadas commented May 24, 2023 •
edited
Loading

This is an automated PR to replace knative-sandbox strings to knative-extension. Do not merge until Rename knative-sandbox org is renamed to knative-extension

See knative/community#169

@knative-prow knative-prow bot added the area/tools Issues or PRs related to internal tools found at /tools label May 24, 2023
@knative-prow
Copy link

knative-prow bot commented May 24, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: davidhadas
Once this PR has been reviewed and has the lgtm label, please assign dprotaso for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from psschwei and upodroid May 24, 2023 08:08
@knative-prow knative-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 24, 2023
@krsna-m
Copy link
Contributor

krsna-m commented May 24, 2023

unit tests are giving valid failures. Please review the test failures

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 24, 2023
@knative-prow-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@davidhadas
Copy link
Contributor Author

davidhadas commented May 25, 2023 •
edited
Loading

@kvmware - not sure what we need to do here next.
The new PR deletes prow/jobs/generated/knative-sandbox, I can reintroduce it and only add prow/jobs/generated/knative-extension
Yet, whenever we will merge this PR, prow/jobs/generated/knative-extension will be an old one... so maybe we need to make this PR only after we rename...

@krsna-m
Copy link
Contributor

krsna-m commented May 25, 2023

Please see: https://cloud-native.slack.com/archives/C04LGHDR9K7/p1684430739022769

@krsna-m krsna-m closed this May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psschwei psschwei Awaiting requested review from psschwei

@upodroid upodroid Awaiting requested review from upodroid

Assignees
No one assigned
Labels
area/tools Issues or PRs related to internal tools found at /tools needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidhadas @krsna-m @knative-prow-robot