-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix config-bootstrapper and test-runner RBAC #3672
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: upodroid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
You have some no newline issues else lgtm |
/hold I had to revert my change earlier. Prow unfortunately doesn't understand different contexts properly. It assumes all users have cluster-admin which isn't good. First order of business is extending config-bootstrapper to use a context. |
A quick fix would be to load a kubeconfig with just only the config-bootstrapper context. |
Also, it is 7 days till the release day so I don't really want to make some changes this week and cause testgrid to show extra flakes from infra changes/snafu |
/hold cancel I created a dedicated secret for it with just a single context. I will experiment with the contexts after the release is done. |
/lgtm |
/cc @dprotaso @kvmware
1st commit fixes the e2e serving errors @dprotaso mentioned
2nd commit fixes the config-bootstrapper errors. Basically, it was pointing to the old prow control plane cluster which I deleted this month.
Contents of the kubeconfig:
I'm working with sig-testing at Kubernetes on getting rid of the bearer tokens and using the gke auth plugins.
kubernetes/test-infra#28142