Rename release jobs to "nightly-release" for clarity #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
the
size/M
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrcunha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
|
/hold Requires #295 to be merged first. |
knative-prow-robot
added
the
do-not-merge/hold
adrcunha
requested review from
srinivashegde86
and removed request for
ericKlawitter and
steuhs
|
This is ready for review. |
|
/lgtm |
|
/hold cancel |
knative-prow-robot
removed
the
do-not-merge/hold
Cynocracy
pushed a commit
to Cynocracy/test-infra
that referenced
this pull request
Jun 13, 2020
* Remove baselogger and use FormatLogger everywhere * Fix blank spaces in README * Fix linting issues * Fix comment to FormatLogger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bonus: update gubernator config with some missing directories.