Use nightly images from knative-nightly #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of knative/serving#2555. Bonus: block running E2E tests using knative-nightly GCR as well.
knative-prow-robot
added
the
size/S
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrcunha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
adrcunha
requested review from
srinivashegde86
and removed request for
steuhs
|
/lgtm |
|
The new GCR/GCS is now populated and public. /retest |
Cynocracy
pushed a commit
to Cynocracy/test-infra
that referenced
this pull request
Jun 13, 2020
* Metrics logging fix in pkg/test: Issue-3150 knative/serving#3150 describes the issue that currently exists in our test logging framework. This change fixes the problem by prefixing metrics that needs to be emited by a constant which the logging.ExpoxtSpan method then uses to identify the spans that needs to be emitted as logs Note this only fixes part of the issue: knative/serving#3150 this change needs to be ported to knative serving before the issue can be closed. * Update test/logging/logging.go Adding required lines. Co-Authored-By: dushyanthsc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of knative/serving#2555.
Bonus: block running E2E tests using knative-nightly GCR as well.