Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prometheus & ceph sources #2435

Merged
merged 1 commit into from
Sep 17, 2020
Merged

Add prometheus & ceph sources #2435

merged 1 commit into from
Sep 17, 2020
+266 −0

Conversation

lberk
Copy link
Member

@lberk lberk commented Sep 17, 2020 •
edited
Loading

What this PR does, why we need it:
This address the prometheus and ceph sources being broken out from eventing-contrib to their respective eventing-foo repositories in sandbox

Which issue(s) this PR fixes:
Fixes: knative/community#234
Fixes: knative/community#237

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 17, 2020
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 17, 2020
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 17, 2020
@lberk
Add eventing-ceph and eventing-prometheus config
d23c4df 
eventing-ceph should run continuous tests (no release artifacts)
eventing-prometheus should run continuous, nightly, and auto-releases
@lberk lberk force-pushed the add-prometheus-ceph-sources branch from 30594de to d23c4df Compare September 17, 2020 01:34
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 17, 2020
@lberk lberk changed the title Add prometheus ceph sources Add prometheus & ceph sources Sep 17, 2020
@lberk lberk mentioned this pull request Sep 17, 2020
Merged
@chizhg
Copy link
Member

chizhg commented Sep 17, 2020

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2020
@knative-prow-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chizhg, lberk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2020
@knative-prow-robot knative-prow-robot merged commit b322017 into knative:master Sep 17, 2020
@knative-prow-robot
Copy link
Collaborator

@lberk: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key config.yaml using file config/prod/prow/jobs/config.yaml

In response to this:

What this PR does, why we need it:
This address the prometheus and ceph sources being broken out from eventing-contrib to their respective eventing-foo repositories in sandbox

Which issue(s) this PR fixes:
Fixes: knative/community#234
Fixes: knative/community#237

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaodaiG chaodaiG Awaiting requested review from chaodaiG

@coryrc coryrc Awaiting requested review from coryrc

Assignees

@chizhg chizhg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New Repo: eventing-prometheus New Repo: eventing-ceph
4 participants
@lberk @chizhg @knative-prow-robot @googlebot