gubernator sometimes fail to report failed tests

[adrcunha]

e.g., in https://gubernator.knative.dev/build/knative-prow/logs/ci-knative-serving-continuous/1039348282343559168 the e2e tests failed but were not reported

[adrcunha]

#118 should solve it, or at least provide a hint on why the report on e2e tests was skipped.

[adrcunha]

Once knative/serving#2042 is merged it will possible to check in knative/serving if this is really solved.

[adrcunha]

Checked the CI flow for knative/build, and didn't find any missing results anymore.

[adrcunha]

Another instance where the results were not parsed correctly:

https://gubernator.knative.dev/build/knative-prow/pr-logs/pull/knative_serving/2063/pull-knative-serving-integration-tests/1045017388094853122/?log#log

I0926 18:47:04.525] FAIL	github.com/knative/serving/test/e2e	518.582s
W0926 18:47:04.626] mv: missing destination file operand after 'knative/serving/test/e2e'
W0926 18:47:04.626] Try 'mv --help' for more information.

[adrcunha]

Another example of missing failure:

https://storage.googleapis.com/knative-prow/pr-logs/pull/knative_serving/2120/pull-knative-serving-unit-tests/1046832725564067840/build-log.txt

I1001 18:53:55.385] - TestBreakerNoOverload :PASS:
I1001 18:53:55.467] - FAIL github.com/knative/serving/pkg/queue
I1001 18:53:55.478] - TestStoreBadConstructors :PASS:
...
I1001 18:53:57.690] === RUN   TestBreakerRecover
I1001 18:53:57.690] SIGQUIT: quit
...
I1001 18:53:57.699] *** Test killed with quit: ran too long (10m0s).
I1001 18:53:57.699] FAIL	github.com/knative/serving/pkg/queue	600.167s
...

The parser doesn't recognize SIGQUIT.

[adrcunha]

In https://gubernator.knative.dev/build/knative-prow/logs/ci-knative-serving-continuous/1052590539603447808:

I1017 16:19:11.334] - FAIL github.com/knative/serving/test/e2e
I1017 16:19:11.338] *** INTERNAL ERROR: missing tests for knative/serving/test/e2e, got []
...
I1017 16:19:11.377] fatal	TestAutoscaleUpDownUp	e2e/autoscale_test.go:219	Unable to observe the Deployment named prodjetisbnn-00001-deployment scaling
...

Looks like the parser missed the fatal entry.

[adrcunha]

The error above happened before library.sh was updated to the latest version, which had a few fixes for handling the fatal case. Also, the autoscale tests were updated as well. Since then there's no evidence in Testgrid that the parser is still missing failures.

[adrcunha]

Considering this fixed.