Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bash v4 to requirements #9797

Merged
merged 1 commit into from
Oct 13, 2020
Merged

Conversation

julz
Copy link
Member

@julz julz commented Oct 13, 2020

The requirement of some of our dev scripts on bash v4+ confused at least one person in #9792, so seems worth documenting.

/assign @n3wscott @mattmoor

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 13, 2020
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 13, 2020
@codecov
Copy link

codecov bot commented Oct 13, 2020

Codecov Report

Merging #9797 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9797      +/-   ##
==========================================
+ Coverage   87.72%   87.77%   +0.04%     
==========================================
  Files         180      180              
  Lines        8553     8553              
==========================================
+ Hits         7503     7507       +4     
+ Misses        799      796       -3     
+ Partials      251      250       -1     
Impacted Files Coverage Δ
pkg/reconciler/configuration/configuration.go 89.16% <0.00%> (+1.66%) ⬆️
pkg/autoscaler/scaling/multiscaler.go 89.74% <0.00%> (+1.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67c36c8...4f3d9b5. Read the comment docs.

Copy link
Contributor

@markusthoemmes markusthoemmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: julz, markusthoemmes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2020
@knative-prow-robot knative-prow-robot merged commit a6cb827 into knative:master Oct 13, 2020
@dprotaso
Copy link
Member

there's actually a debate about this going on here:
knative/test-infra#2143

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants