-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bash v4 to requirements #9797
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9797 +/- ##
==========================================
+ Coverage 87.72% 87.77% +0.04%
==========================================
Files 180 180
Lines 8553 8553
==========================================
+ Hits 7503 7507 +4
+ Misses 799 796 -3
+ Partials 251 250 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: julz, markusthoemmes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
there's actually a debate about this going on here: |
The requirement of some of our dev scripts on bash v4+ confused at least one person in #9792, so seems worth documenting.
/assign @n3wscott @mattmoor