Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove occurrences of 'whitelist' and 'master'. #9328

Merged
merged 1 commit into from
Sep 8, 2020

Conversation

markusthoemmes
Copy link
Contributor

Proposed Changes

In accordance to knative/community#193 this gets rid of a few of the easier replacement suggestions. The only remaining mentions are the binary flags which we'll take care off in pkg (sharedmain) first.

Release Note

NONE

/assign @mattmoor @evankanderson @grantr @tcnghia

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 8, 2020
@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 8, 2020
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markusthoemmes: 0 warnings.

In response to this:

Proposed Changes

In accordance to knative/community#193 this gets rid of a few of the easier replacement suggestions. The only remaining mentions are the binary flags which we'll take care off in pkg (sharedmain) first.

Release Note

NONE

/assign @mattmoor @evankanderson @grantr @tcnghia

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added area/API API objects and controllers area/test-and-release It flags unit/e2e/conformance/perf test issues for product features labels Sep 8, 2020
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markusthoemmes, mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit f5b435f into knative:master Sep 8, 2020
@@ -138,7 +138,7 @@ func TestPodIPsSortedByAge(t *testing.T) {
}, {
name: "one pod",
pods: []*corev1.Pod{
pod("master-of-puppets", makeReady, withStartTime(aTime), withIP("1.1.1.1")),
pod("foo", makeReady, withStartTime(aTime), withIP("1.1.1.1")),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

foo is not appropriate here :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/test-and-release It flags unit/e2e/conformance/perf test issues for product features cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants