Update go-containerregistry to the latest revision. #7106
Conversation
knative-prow-robot
added
the
size/XXL
There was a problem hiding this comment.
@markusthoemmes: 0 warnings.
In response to this:
Proposed Changes
This hasn't been updated for quite a while so I thought we might want to bite the bullet and do it. The newer versions also contain a fix that enables us Openshift to run Knative on a GCP base.
Release Note
NONE/assign @mattmoor
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
| revision = "ba53fa10e72c7373ef8068e21c9f102f0c20a940" | ||
|
|
||
| [[override]] | ||
| name = "github.com/vdemeester/k8s-pkg-credentialprovider" |
There was a problem hiding this comment.
It is probably notable that this removes one of the blockers for Go module support
There was a problem hiding this comment.
Right, I'll add that to the description for more weight!
|
/hold |
knative-prow-robot
added
do-not-merge/hold
|
@mattmoor is this one good to go now? |
|
/hold cancel |
knative-prow-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markusthoemmes, mattmoor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
* Update go-containerregistry to the latest revision. * Fix date.
…d build flag. (#413) * Use buildflag to workaround gcp behavior. * [CP] Update go-containerregistry to the latest revision. (knative#7106) * Update go-containerregistry to the latest revision. * Fix date. * Use proper location for flag. Co-authored-by: Knative Prow Robot <[email protected]>
Fixes for Openshift on GCP: knative#7106 Fixes for EKS/ECR: knative#7244
Fixes for Openshift on GCP: knative#7106 Fixes for EKS/ECR: knative#7244
Proposed Changes
This hasn't been updated for quite a while so I thought we might want to bite the bullet and do it. The newer versions also contain a fix that enables us Openshift to run Knative on a GCP base.
The dependency change in go-containerregistry also resolves a go-module blocker.
Release Note
/assign @mattmoor