Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set memory request for zipkin pods #4353

Merged
merged 2 commits into from
Jun 14, 2019
Merged

Set memory request for zipkin pods #4353

merged 2 commits into from
Jun 14, 2019

Conversation

sebgoa
Copy link
Contributor

@sebgoa sebgoa commented Jun 13, 2019

/lint

Fixes #4342

Proposed Changes

  • Set a memory request of 256Mi for zipkin.

This lowers the memory necessary to schedule the zipkin pod. In #4342 you will see link to upstream openzipkin issue that give confidence this is a sane number.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 13, 2019
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 13, 2019
@yanweiguo
Copy link
Contributor

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sebgoa, yanweiguo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2019
@sebgoa
Copy link
Contributor Author

sebgoa commented Jun 14, 2019

/test pull-knative-serving-smoke-tests

@knative-prow-robot knative-prow-robot merged commit 92a866d into knative:master Jun 14, 2019
@sebgoa sebgoa deleted the zipkinlean branch June 17, 2019 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/monitoring cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce memory request for zipkin pod
4 participants