Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump "safe" dependencies #2697

Merged
merged 14 commits into from
Jan 4, 2019
Merged

Conversation

vdemeester
Copy link
Member

@vdemeester vdemeester commented Dec 11, 2018

This bump some "safe" dependencies atomically (as 1 update per commit). By "safe" dependency, I means it tried to update dependency that are not constrained, nor overridden, and that do not track master.

This has been done using sec, which mens:

  • It tried to update the dependency
  • Ran tests to validate it doesn't break (at least the build) (go test ./... or go test ./pkg/..., …).
  • Commit if the test command was successful.

sec is really experimental, but my end-goal is to have some kind of bot that could update those safe deps for us 👼.
Also, this never update to latest either (if latest is the latest release, even if it's a major version bump). It's only updating minor or fixes versions.

Related PR "upstream" knative/pkg#200

/assign @mattmoor

@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 11, 2018
Signed-off-by: Vincent Demeester <[email protected]>
@vdemeester
Copy link
Member Author

/test pull-knative-serving-go-coverage

@mattmoor
Copy link
Member

mattmoor commented Jan 4, 2019

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 4, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2019
@knative-prow-robot knative-prow-robot merged commit f7166e7 into knative:master Jan 4, 2019
@vdemeester vdemeester deleted the bump-dep branch January 4, 2019 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants