Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test-infra #2691

Merged
merged 1 commit into from
Dec 11, 2018
Merged

Update test-infra #2691

merged 1 commit into from
Dec 11, 2018

Conversation

adrcunha
Copy link
Contributor

Major changes:

  • set KO_DATA_PATH for E2E tests
  • update path of shared test-infra code
  • enhanced test summary in the test logs

Bonus: properly fixes #2458.

@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 10, 2018
knative-prow-robot
knative-prow-robot reviewed Dec 10, 2018
View reviewed changes
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adrcunha: 0 warnings.

In response to this:

Major changes:

  • set KO_DATA_PATH for E2E tests
  • update path of shared test-infra code
  • enhanced test summary in the test logs

Bonus: properly fixes #2458.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adrcunha
Copy link
Contributor Author

/assign @mattmoor

@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 10, 2018
@adrcunha
Copy link
Contributor Author

/retest

1 similar comment
@adrcunha
Copy link
Contributor Author

/retest

@adrcunha
Update test-infra
6bddf3c 
Major changes:
* set KO_DATA_PATH for E2E tests
* update path of shared test-infra code
* enhanced test summary in the test logs
@srinivashegde86
Copy link
Contributor

/test pull-knative-serving-go-coverage

@knative-prow-robot
Copy link
Contributor

@adrcunha: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-knative-serving-go-coverage 6bddf3c link /test pull-knative-serving-go-coverage

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@adrcunha
Copy link
Contributor Author

@srinivashegde86 the go coverage job is failing, I already filed knative/test-infra#308 and assigned to Stephen take a look. At least it's not a blocker for PRs.

@srinivashegde86
Copy link
Contributor

ok. sg.

@srinivashegde86
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2018
mattmoor
mattmoor reviewed Dec 11, 2018
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrcunha, mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2018
@knative-prow-robot knative-prow-robot merged commit 6a2b0cd into knative:master Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

@mattmoor mattmoor mattmoor left review comments

@jessiezcc jessiezcc Awaiting requested review from jessiezcc

@srinivashegde86 srinivashegde86 Awaiting requested review from srinivashegde86

Assignees

@srinivashegde86 srinivashegde86

@mattmoor mattmoor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set KO_DATA_PATH when running tests
4 participants
@adrcunha @srinivashegde86 @knative-prow-robot @mattmoor