Refactor global resync tests to use our "hooks" package. #2685
Conversation
knative-prow-robot
added
the
size/L
There was a problem hiding this comment.
@mattmoor: 0 warnings.
In response to this:
I spent a little time looking at #2443 and it seemed like a good use of the hook stuff that @grantr put together in the early days of knative/serving.
Running this with high iteration counts locally, I still see occasional errors, so I'm not going to close out the linked issue, but I feel like this is a step in the right direction as this library has been fairly well worn at this point.
Related: #2443
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
knative-prow-robot
added
the
approved
|
LOL, I toldja it was still flaky! /facepalm |
mattmoor
changed the title
knative-prow-robot
added
the
do-not-merge/work-in-progress
|
I may have to actually fix the flakes to get this through, after I find them. |
I spent a little time looking at knative#2443 and it seemed like a good use of the hook stuff that @grantr put together in the early days of knative/serving. Running this with high iteration counts locally, I still see occasional errors, so I'm not going to close out the linked issue, but I feel like this is a step in the right direction as this library has been fairly well worn at this point. Related: knative#2443
mattmoor
force-pushed
the
refactor-global-resync-tests
branch
from
e7977df
to
3033736
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattmoor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mattmoor
changed the title
knative-prow-robot
removed
the
do-not-merge/work-in-progress
|
/retest |
|
/lgtm |
I spent a little time looking at #2443 and it seemed like a good use of the hook stuff that @grantr put together in the early days of knative/serving.
Running this with high iteration counts locally, I still see occasional errors, so I'm not going to close out the linked issue, but I feel like this is a step in the right direction as this library has been fairly well worn at this point.
Related: #2443