helper funcs for route reconciler to construct ClusterIngress #2298
Conversation
knative-prow-robot
added
area/networking
size/XL
There was a problem hiding this comment.
@lichuqiang: 0 warnings.
In response to this:
Proposed Changes
- helper funcs to construct clusteringress
- create placeholder service according to ingress status
Release Note
update route reconciler to create ClusterIngress instead of VirtualService/area networking
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
| // The purpose of this service is to provide a domain name for Istio routing. | ||
| // TODO: It is to replace the "MakeK8sService" func after route reconciler is switched to reconcile | ||
| // ClusterIngress. | ||
| func NewMakeK8sService(route *v1alpha1.Route, ingress *netv1alpha1.ClusterIngress) (*corev1.Service, error) { |
There was a problem hiding this comment.
Here I rename the new func to avoid conflict.
Will remove the old one once we finally switch to the new pattern in reconciler.
|
The following is the coverage report on pkg/.
|
| @@ -159,48 +159,6 @@ func TestMakeVirtualServiceSpec_CorrectRoutes(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestGetRouteDomains_NamelessTarget(t *testing.T) { | |||
There was a problem hiding this comment.
Can we just move these tests to cluster_ingress_test.go instead of deleting?
There was a problem hiding this comment.
I think we have (see cluster_ingress_test.go#L137).
knative-prow-robot
added
the
approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lichuqiang, tcnghia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks for splitting this off @lichuqiang ! |
Part of #1963
Follow-up #2189
Proposed Changes
Release Note
/area networking
/assign @tcnghia @mattmoor