-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 202-gateway.yaml to match Istio 1.0.2's istio.yaml. #2265
Conversation
/assign @ZhiminXiang |
/lgtm |
/assign @vaikas-google |
/lgtm |
and to double-check, you still want to leave the gateway at 1.0.1? |
@vaikas-google in their official release Istio still label their Helm chart 1.0.1 but the image tags are all updated to 1.0.2 (see Git tag 1.0.2 here https://github.com/istio/istio/blob/1.0.2/install/kubernetes/helm/istio/Chart.yaml) . Here I am keeping the chart label consistent with the upstream 1.0.2 manifest, only moving the image tag (also consistent with their 1.0.2 manifest) |
@vaikas-google This PR also changes back the knative-ingressgateway Deployment from /cc @lichuqiang |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tcnghia, vaikas-google, ZhiminXiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The change seems to break upgrade from previous version, since Spec.Selector is an immutable field.
The change seems to break upgrade from previous version, since Spec.Selector is an immutable field.
Proposed Changes
Update
knative-ingressgateway
pods to match Istio 1.0.2's settings.After #1963 is done we can proceed to #1969 which should allow us to move to using Istio's gateway pods by default so we don't have to keep doing this.