Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 202-gateway.yaml to match Istio 1.0.2's istio.yaml. #2265

Merged
merged 1 commit into from
Oct 19, 2018

Conversation

tcnghia
Copy link
Contributor

@tcnghia tcnghia commented Oct 19, 2018

Proposed Changes

Update knative-ingressgateway pods to match Istio 1.0.2's settings.

After #1963 is done we can proceed to #1969 which should allow us to move to using Istio's gateway pods by default so we don't have to keep doing this.

@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 19, 2018
@tcnghia
Copy link
Contributor Author

tcnghia commented Oct 19, 2018

/assign @ZhiminXiang

@lichuqiang
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2018
@tcnghia
Copy link
Contributor Author

tcnghia commented Oct 19, 2018

/assign @vaikas-google

@ZhiminXiang
Copy link

/lgtm
/approve

@vaikas
Copy link
Contributor

vaikas commented Oct 19, 2018

and to double-check, you still want to leave the gateway at 1.0.1?

@tcnghia
Copy link
Contributor Author

tcnghia commented Oct 19, 2018

and to double-check, you still want to leave the gateway at 1.0.1?

@vaikas-google in their official release Istio still label their Helm chart 1.0.1 but the image tags are all updated to 1.0.2 (see Git tag 1.0.2 here https://github.com/istio/istio/blob/1.0.2/install/kubernetes/helm/istio/Chart.yaml) . Here I am keeping the chart label consistent with the upstream 1.0.2 manifest, only moving the image tag (also consistent with their 1.0.2 manifest)

@tcnghia
Copy link
Contributor Author

tcnghia commented Oct 19, 2018

@vaikas-google This PR also changes back the knative-ingressgateway Deployment from apps/v1 to extensions/v1beta1 (undoing one line in https://github.com/knative/serving/pull/2110/files). However since this is copied from Istio's templates I feel that it is best to keep things consistent with minimal changes.

/cc @lichuqiang

@vaikas
Copy link
Contributor

vaikas commented Oct 19, 2018

/lgtm
/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tcnghia, vaikas-google, ZhiminXiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2018
@knative-prow-robot knative-prow-robot merged commit 80dfb20 into knative:master Oct 19, 2018
tcnghia pushed a commit to tcnghia/serving that referenced this pull request Oct 19, 2018
The change seems to break upgrade from previous version, since
Spec.Selector is an immutable field.
knative-prow-robot pushed a commit that referenced this pull request Oct 19, 2018
The change seems to break upgrade from previous version, since
Spec.Selector is an immutable field.
mgencur pushed a commit to mgencur/serving-1 that referenced this pull request Oct 26, 2018
mgencur pushed a commit to mgencur/serving-1 that referenced this pull request Oct 26, 2018
The change seems to break upgrade from previous version, since
Spec.Selector is an immutable field.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants